Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/workaround for #204 #124

Merged
merged 20 commits into from
May 18, 2024
Merged

Fix/workaround for #204 #124

merged 20 commits into from
May 18, 2024

Conversation

sander1988
Copy link
Owner

@sander1988 sander1988 commented Nov 12, 2023

@sander1988 sander1988 changed the base branch from master to develop November 12, 2023 14:28
sander1988 and others added 14 commits December 2, 2023 13:47
Added option to override the User-Agent (for #204).
Signed-off-by: Rosi2143 <Schrott.Micha@web.de>
make tests work with new SingleKey authorization method
Signed-off-by: Rosi2143 <Schrott.Micha@web.de>
adapt test_config to SingleKeyID
Signed-off-by: Rosi2143 <Schrott.Micha@web.de>
Raise exception on all other type of serverside (4XX) errors.
Use the same logging format for all request log messages.
README: Add contribution setup
Signed-off-by: Rosi2143 <Schrott.Micha@web.de>
Signed-off-by: Rosi2143 <Schrott.Micha@web.de>
@Rosi2143
Copy link
Collaborator

Hi,

can you please rebase the MR to the latest version of "develop" - now the tests are working again.

Thanks.

Fixed bug in setup.py where version file loading failed due to missing deps.
@sander1988
Copy link
Owner Author

sander1988 commented May 17, 2024

Hi,

can you please rebase the MR to the latest version of "develop" - now the tests are working again.

Thanks.

I have merged everything and also applied a fix to setup.py.

There was a bug in the version load logic as the import of version.py also imports the package (__ init __.py) which imports the pip deps. That would fail as setup.py didn't yet completed installing them.

This pull request shows more changes than I would have expected. But it seems the master of this repo is ahead of the develop branch, that's why. Is that correct?

@Rosi2143
Copy link
Collaborator

Hi @sander1988,

yes - I changes some settings to make tests run again correctly with the new loging method - and did this first on master.
While beeing at it I also changes some typos, flake8 warnings and format issues - which I should have done only on develop 😞.

Thanks for your changes - they look good.

I'm still looking for a nice way to get the "token" - do you have an easy way to get it?

@Rosi2143 Rosi2143 merged commit c817b7e into sander1988:develop May 18, 2024
1 check passed
@sander1988
Copy link
Owner Author

I'm still looking for a nice way to get the "token" - do you have an easy way to get it?
@Rosi2143 - Yes that's probably possible. Can you drop a message in Discord with some details about what you are trying to achieve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants