Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLP Mixer on architectures #17

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Add MLP Mixer on architectures #17

merged 4 commits into from
Jul 11, 2024

Conversation

HenryMantilla
Copy link
Collaborator

@HenryMantilla HenryMantilla commented Jul 7, 2024

Description

Added MLP Mixer architecture proposed in "MLP-Mixer: An all-MLP Architecture for Vision"

Checklist

Ensure your pull request meets the following requirements:

  • I have reviewed existing notebooks to avoid duplications.
  • My notebook is fully executed.
  • I have included a list of all libraries and their versions used in the notebook.
  • The notebook file is named clearly to reflect the topic (e.g., cross-entropy-loss.ipynb).
  • I have placed the notebook in the appropriate directory under notebooks/.
  • My code is simple, precise, and adheres to good coding practices.

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thank you. Just a comment, you are not using the image size parameter, you could remove it, although I can approve it that way.

@HenryMantilla
Copy link
Collaborator Author

Solved unused parameter in patch embedding class

@guillepinto guillepinto merged commit 0f24840 into main Jul 11, 2024
@guillepinto guillepinto deleted the feat/mlp-mixer branch July 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants