Add prebuilt mozjs archive CI #454

wusyong · 2024-02-29T09:46:22Z

Another part of #439. This PR adds a CI pipeline to publish prebuilt mozjs archive.
I've tried to run it and created a working version release: https://github.com/wusyong/mozjs/releases/tag/2024-02-29
I set the workflow trigger on the main branch update since there are few commits for this repo.
Let me know if there's preferred condition.

sagudev

I am not really fan of doing manual uploads using curl commands. We should use actions to make this less complex. You can take a look how this is done in servo: https://github.com/servo/servo/blob/main/.github/workflows/nightly.yml. In servo we also mark releases that are not full as draft (and mark them as final if all runs succeed).

I think mac-arm and x86 could be merged into one job with matrix.

sagudev · 2024-02-29T10:02:15Z

Furthermore I think we can simply use main workflow insted of adding new one and add MOZJS_CRATE_ARCHIVE=1 to main (as it does not change an compilation only adds packaging step), the upload archives as artifects and if run as done on landing (push to main) actually release artifacts as GitHub release. This should avoid us repeating a lot of lines and allow faster testing of ARCHIVES (as they are stored as artifacts also on forks).

sagudev · 2024-02-29T10:03:08Z

Then there is also option to start CI on release, that could check that archives actually work.

wusyong · 2024-02-29T10:52:15Z

Alright! Let me move the workflow into main one. I use curl because I didn't find any action could move action artifact to release asset, and actions/upload-release-asset is unmaintained. Do you have any recommended action that can upload artifact first and then move to release asset later? Edit: I think I can create two steps instead. Let me test them a bit later.

Move CI into one file

sagudev · 2024-03-01T06:12:37Z

I am not sure we want to do releases on forks. Only on servo/servo would be enough (but only for push to main, we would want to make release for every PR). There is github.event_name for this IIRC.

Also to simplify things even more, instead of firstly creating draft release we should just do normal run uploading archives as artifacts (already done). Then at the end do release job that would download all artifacts and upload them all to the release.

Also upload-release-asset@v1 seems to be unmaintained, maybe we can do this by gh command.

wusyong · 2024-03-01T09:28:14Z

I need github.repository_owner to test on my own fork. I can make it only releases on servo/mozjs.

Also to simplify things even more, instead of firstly creating draft release we should just do normal run uploading archives as artifacts (already done).

I'll simplify the workflow a bit. I also aware of gh command but have some trouble with multiple build steps. Maybe it can be easier if the release workflow is simplified.

Simplify release workflow

wusyong · 2024-03-01T12:22:05Z

Tested and released by simplified job. Let me know if there is something need improved.
I'll work on a CI job to verify release asset can be built and tested.

.github/workflows/rust.yml

wusyong · 2024-03-02T11:04:54Z

There are some restrictions on recursive calls on workflow and auto release. So I chose workflow_call to create another workflow to check release binaries. Here's the successful action that creates a release and verify on my fork.

I think that's all for the workflow that can create releases and then verify it when the release is published. Let me know if I still miss or need to fix something.

sagudev · 2024-03-03T13:57:18Z

There are some restrictions on recursive calls on workflow and auto release.

I completely forgot about those. Does it fail running release CI job or does it just not get run. If it's the later case we might still want to have it trigger on release (in addition to workflow call) in case we do manual release.

.github/workflows/release.yml

Update trigger condition and remove deps

wusyong · 2024-03-04T05:50:50Z

I completely forgot about those. Does it fail running release CI job or does it just not get run. If it's the later case we might still want to have it trigger on release (in addition to workflow call) in case we do manual release.

It won't be triggered to run. I'll add the condition to trigger on manual release.

.github/workflows/release.yml

Merge all jobs in release into one

Update release jobs

sagudev · 2024-03-05T15:09:54Z

.github/workflows/rust.yml

+      - id: release
+        if: ${{ github.ref == 'refs/heads/main' && github.event_name == 'push' }}
+        run: |
+          RELEASE_TAG=$(date "+%F-%H-%M")


This could be problematic, if we have two updates in a day (it happens sometimes), so using commit hash might be better, but I don't know how we could bake this info in for #450. Can we get dependency commit hash using cargo without baking it in.

Rusty_v8 does this using CARGO_PKG_VERSION:
https://github.com/denoland/rusty_v8/blob/9dd629e1c3c50fbbe70435ed50f6f09e9b69d7bb/build.rs#L320

CARGO_PKG_VERSION seems like a better approach. I also hope this repo can provide version release again.
I'll update release job to use mozjs_sys's CARGO_PKG_VERSION, and it will skip the release if the version is already exist.

I think CARGO_PKG_VERSION is actually the only way to go and because we moved all .c* files to mozjs-sys, the only thing that needs versions bumps is mozjs-sys when there are any C/C++ file changes.

It would be nice to make CI check for this too, but I think this can be done as a followup if (ever) needed. For now I think it would be enough if we test always latest release on push to main (instead of testing release only if it's new).

Update release tag name and check if exist before release

.github/workflows/rust.yml

sagudev · 2024-03-08T19:18:12Z

We should not fail here, right?

a release with the same tag name already exists: mozjs-sys-v0.68.2

https://github.com/sagudev/mozjs/actions/runs/8207125754/job/22448383805#step:5:11

sagudev · 2024-03-08T19:20:05Z

I think we should just skip release creation in this case, but still verify it.

wusyong · 2024-03-09T05:21:29Z

We should not fail here, right?

a release with the same tag name already exists: mozjs-sys-v0.68.2

https://github.com/sagudev/mozjs/actions/runs/8207125754/job/22448383805#step:5:11

This SO question looks similar to us. I'll add git fetch --tags before checking.

sagudev · 2024-03-09T06:20:32Z

We should not fail here, right?

a release with the same tag name already exists: mozjs-sys-v0.68.2

https://github.com/sagudev/mozjs/actions/runs/8207125754/job/22448383805#step:5:11

This SO question looks similar to us. I'll add git fetch --tags before checking.

I am not sure this will solve it. I simply run workflow twice (second time with empty commit), both times on main. I think we just need to not fail in this case. So maybe something like gh create release ... || exit 0.

sagudev · 2024-03-09T06:23:04Z

.github/workflows/rust.yml

+          if git show-ref --tags --verify --quiet "refs/tags/${RELEASE_TAG}"; then
+            RELEASE_TAG=''
+          fi 


Or did you refer to that code? In that case we can simply remove this and make next step to not fail, which will ensure to test all merged commits with latest release available.

Oh sorry I didn't read your comments before pushing. gh create release ... || exit 0 seems simpler. I'll update it.

What you did is actually way better, because using || we hide all gh create release failures.

ah okay! Let me revert it. 😅

Edit: Here's my run with second try: https://github.com/wusyong/mozjs/actions/runs/8212872566

sagudev · 2024-03-09T08:14:02Z

.github/workflows/rust.yml

+          RELEASE_TAG=mozjs-sys-v$(cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name == "mozjs_sys") | .version')
+          git fetch --tags --quiet
+          if ! git show-ref --tags --verify --quiet "refs/tags/${RELEASE_TAG}" ; then
+            gh release create ${{ steps.check-tag.outputs.RELEASE_TAG }} ./*.tar.gz


${{ steps.check-tag.outputs.RELEASE_TAG }} is not available here yet (step is not finished), but ${RELEASE_TAG} should work. https://github.com/sagudev/mozjs/actions/runs/8213051004/job/22464164401#step:4:5

sagudev

Thanks for all your great work!

I can't wait to start using this work in servo.

wusyong · 2024-03-09T10:39:12Z

@sagudev Thanks for reviewing the PR too! I'll have to work on multi webview suppoer PR next.
But once it's done, I'll get back and update #450.

wusyong added 3 commits February 29, 2024 15:59

Add release CI pipeline

6aef1eb

Rename CI pipeline

ad84256

Update CI trigger condition

c5bf7c2

sagudev reviewed Feb 29, 2024

View reviewed changes

wusyong added 3 commits February 29, 2024 20:05

Merge CI into one file

d3e69ac

Add release steps

7c1b25a

Merge pull request #13 from wusyong/mozjs_release_patch

a29f3a0

Move CI into one file

Update widnow target arguments

83793f4

wusyong added 2 commits March 1, 2024 21:18

Simplify release workflow

d150367

Merge pull request #17 from wusyong/mozjs_patch

0737a22

Simplify release workflow

sagudev reviewed Mar 1, 2024

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

Add release check CI

0b3f0b5

wusyong requested a review from sagudev March 2, 2024 11:05

sagudev reviewed Mar 3, 2024

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

wusyong added 3 commits March 4, 2024 12:46

Update trigger condition and remove deps

9790c30

Add CARGO_TARGET_DIR on Windows job

2e0efed

Merge pull request #21 from wusyong/gh

3c94562

Update trigger condition and remove deps

sagudev reviewed Mar 4, 2024

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

sagudev reviewed Mar 4, 2024

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

wusyong added 2 commits March 4, 2024 15:52

Merge all jobs in release into one

a8370a3

Merge pull request #24 from wusyong/onejob

2076043

Merge all jobs in release into one

wusyong added 2 commits March 5, 2024 15:12

Update release jobs

713e84e

Merge pull request #29 from wusyong/rj

495e7e5

Update release jobs

wusyong requested a review from sagudev March 5, 2024 07:03

sagudev reviewed Mar 5, 2024

View reviewed changes

wusyong added 2 commits March 6, 2024 16:02

Update release tag name and check if exist before release

b154d0a

Merge pull request #31 from wusyong/ct

3241ac0

Update release tag name and check if exist before release

wusyong requested a review from sagudev March 6, 2024 07:21

sagudev reviewed Mar 6, 2024

View reviewed changes

.github/workflows/rust.yml Show resolved Hide resolved

sagudev mentioned this pull request Mar 6, 2024

Bump mozjs_sys version to 0.115.7-0 #456

Merged

wusyong requested a review from sagudev March 7, 2024 03:52

wusyong force-pushed the mozjs_release branch from 9de4716 to 3241ac0 Compare March 7, 2024 05:32

sagudev reviewed Mar 9, 2024

View reviewed changes

wusyong and others added 4 commits March 9, 2024 15:34

Update release job to check remote tags

8d7ed20

Simplify release job steps instead

fb6869e

Revert latest commit

a58bfe9

Merge branch 'main' into mozjs_release

21f9113

sagudev reviewed Mar 9, 2024

View reviewed changes

Fix tag variable

3809e36

sagudev force-pushed the mozjs_release branch from 30bd213 to 3809e36 Compare March 9, 2024 09:25

sagudev approved these changes Mar 9, 2024

View reviewed changes

sagudev enabled auto-merge March 9, 2024 09:50

sagudev added this pull request to the merge queue Mar 9, 2024

Merged via the queue into servo:main with commit 20f7934 Mar 9, 2024
40 checks passed

wusyong deleted the mozjs_release branch March 9, 2024 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add prebuilt mozjs archive CI #454

Add prebuilt mozjs archive CI #454

wusyong commented Feb 29, 2024

sagudev left a comment

sagudev commented Feb 29, 2024

sagudev commented Feb 29, 2024

wusyong commented Feb 29, 2024 •

edited

Loading

sagudev commented Mar 1, 2024 •

edited

Loading

wusyong commented Mar 1, 2024

wusyong commented Mar 1, 2024

wusyong commented Mar 2, 2024

sagudev commented Mar 3, 2024 •

edited

Loading

wusyong commented Mar 4, 2024

sagudev Mar 5, 2024

sagudev Mar 5, 2024

wusyong Mar 6, 2024 •

edited

Loading

sagudev Mar 6, 2024

sagudev commented Mar 8, 2024

sagudev commented Mar 8, 2024

wusyong commented Mar 9, 2024

sagudev commented Mar 9, 2024

sagudev Mar 9, 2024

wusyong Mar 9, 2024

sagudev Mar 9, 2024 •

edited

Loading

wusyong Mar 9, 2024 •

edited

Loading

sagudev Mar 9, 2024

sagudev left a comment

wusyong commented Mar 9, 2024

Add prebuilt mozjs archive CI #454

Add prebuilt mozjs archive CI #454

Conversation

wusyong commented Feb 29, 2024

sagudev left a comment

Choose a reason for hiding this comment

sagudev commented Feb 29, 2024

sagudev commented Feb 29, 2024

wusyong commented Feb 29, 2024 • edited Loading

sagudev commented Mar 1, 2024 • edited Loading

wusyong commented Mar 1, 2024

wusyong commented Mar 1, 2024

wusyong commented Mar 2, 2024

sagudev commented Mar 3, 2024 • edited Loading

wusyong commented Mar 4, 2024

sagudev Mar 5, 2024

Choose a reason for hiding this comment

sagudev Mar 5, 2024

Choose a reason for hiding this comment

wusyong Mar 6, 2024 • edited Loading

Choose a reason for hiding this comment

sagudev Mar 6, 2024

Choose a reason for hiding this comment

sagudev commented Mar 8, 2024

sagudev commented Mar 8, 2024

wusyong commented Mar 9, 2024

sagudev commented Mar 9, 2024

sagudev Mar 9, 2024

Choose a reason for hiding this comment

wusyong Mar 9, 2024

Choose a reason for hiding this comment

sagudev Mar 9, 2024 • edited Loading

Choose a reason for hiding this comment

wusyong Mar 9, 2024 • edited Loading

Choose a reason for hiding this comment

sagudev Mar 9, 2024

Choose a reason for hiding this comment

sagudev left a comment

Choose a reason for hiding this comment

wusyong commented Mar 9, 2024

wusyong commented Feb 29, 2024 •

edited

Loading

sagudev commented Mar 1, 2024 •

edited

Loading

sagudev commented Mar 3, 2024 •

edited

Loading

wusyong Mar 6, 2024 •

edited

Loading

sagudev Mar 9, 2024 •

edited

Loading

wusyong Mar 9, 2024 •

edited

Loading