style: changed former Twitter logo & updated styles #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I replaced the former Twitter logo using FontAwesome's <FontAwesomeIcon /> React component in order to be consistent with the initial codebase (referencing line 50 in Profile.jsx file where the above-mentioned component is already used). I also did the same with other icons for consistency. In addition, I added 'social-icon' className for further stylization of the component.
I updated styles for newly changed icons (now using <FontAwesomeIcon> component instead of <i>). Also optimized the way of centering the icon w/o magic values. Apapted scale hover effect of the icon to work properly with new elements.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @feelthatvib3! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
shyamtawli
added
enhancement
|
@feelthatvib3 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed former Twitter logo and adapted styles to new changes.
Related Issues
#470
Changes Proposed
A full description comes from commits as well as the title.
Checklist
Screenshots
Note to reviewers
None.