Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unknown states from _on_charging_event #610

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix unknown states from _on_charging_event #610

merged 2 commits into from
Feb 4, 2025

Conversation

prvakt
Copy link
Collaborator

@prvakt prvakt commented Feb 4, 2025 •
edited
Loading

There were couple of places inside _on_charging_event() where state was assigned without checking if its exists in the event data which caused sensor to go to unknown state in some cases as described in #608

@prvakt prvakt added the bug Something isn't working label Feb 4, 2025
@prvakt prvakt requested a review from WebSpider February 4, 2025 14:57
@prvakt prvakt changed the title fix unavailable states from _on_charging_event fix unknown states from _on_charging_event Feb 4, 2025
This was linked to issues Feb 4, 2025
KODIAQ - auxiliary heater switch returning error 500 #586
Closed
Periodic updates are deferred when charging is in progress #608
Closed
@prvakt prvakt removed a link to an issue Feb 4, 2025
KODIAQ - auxiliary heater switch returning error 500 #586
Closed
WebSpider
WebSpider approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@prvakt prvakt merged commit 160fa72 into skodaconnect:main Feb 4, 2025
3 checks passed
@prvakt prvakt deleted the fix_unavailable_soc_when_charging branch February 4, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebSpider WebSpider WebSpider approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Periodic updates are deferred when charging is in progress
2 participants
@prvakt @WebSpider