Switch bad row type from EnrichmentFailures to SchemaViolations for s… #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Looks good @benjben!
Regarding my suggested improvement... I have not assessed this needs changing in more places than just the place I highlighted. If you assess that it stretches far beyond just the bits of code that you changed here, then maybe it needs to be its own separate commit.
(Or, of course, reject my idea outright)
...a/com.snowplowanalytics.snowplow.enrich/common/enrichments/AtomicFieldsLengthValidator.scala
Outdated
Show resolved
Hide resolved
.../main/scala/com.snowplowanalytics.snowplow.enrich/common/enrichments/EnrichmentManager.scala
Outdated
Show resolved
Hide resolved
istreeter
reviewed
Mar 6, 2024
.../main/scala/com.snowplowanalytics.snowplow.enrich/common/enrichments/EnrichmentManager.scala
Outdated
Show resolved
Hide resolved
.../main/scala/com.snowplowanalytics.snowplow.enrich/common/enrichments/EnrichmentManager.scala
Outdated
Show resolved
Hide resolved
…ome errors There are 3 places that currently produce an EnrichmentFailures bad row whereas the more appropriate type is SchemaViolations: 1. When the input fields of the HTTP requests are mapped to the atomic event. 2. When the enrichments contexts get validated. 3. When the atomic fields lengths get validated. For 1 and 3, the error should be mapped into an Iglu ValidationError with the atomic schema referenced. Before this change, if there was any error in the mapping of the atomic fields, a bad row would get emitted right away and we would not try to validate the entities and unstruct event. Now all these errors are wrapped inside a same SchemaViolations bad row. Likewise, before this change when an enrichment context was invalid, we were emitting a bad row right away and not checking the lengths of the atomic fields. Now all these errors are wrapped inside a same SchemaViolations bad row.
benjben
force-pushed
the
switch_to_schema_violations
branch
from
378fe6c to
9846a2f
Compare
|
Hey @istreeter , I addressed all your feedback, please have a look |
istreeter
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 places that currently produce an
EnrichmentFailuresbad row whereas the more appropriate type isSchemaViolations:For 1 and 3, the error should be mapped into an Iglu
ValidationErrorwith the atomic schema referenced.Before this change, if there was any error in the mapping of the atomic fields, a bad row would get emitted right away and we would not try to validate the entities and unstruct event. Now all these errors are wrapped inside a same
SchemaViolationsbad row.Likewise, before this change when an enrichment context was invalid, we were emitting a bad row right away and not checking the lengths of the atomic fields. Now all these errors are wrapped inside a same
SchemaViolationsbad row.