feat_: disable prior tx history fetching for all accounts #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
✔️ status-go/prs/tests/PR-5786#1 🔹 ~34 min 🔹 b43bacc 🔹 📦 tests package |
dlipicar
force-pushed
the
feat/disable-tx-history-fetch-for-all-accounts
branch
from
b43bacc to
8ae4322
Compare
dlipicar
changed the title
dlipicar
commented
Aug 29, 2024
| } | ||
| } | ||
|
|
||
| const omitHistory = true |
There was a problem hiding this comment.
mainly relevant part
There was a problem hiding this comment.
also, constant kept for meaning, this will go away with future cleanups
alaibe
approved these changes
Aug 30, 2024
saledjenic
approved these changes
Sep 2, 2024
igor-sirotin
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables fetching of past transactions (prior to the addition of the account to Status) for all accounts. This used to be done only for newly-generated accounts, now it includes imported ones as well.
A related setting is removed as well.
This doesn't affect fetching transactions triggered from Status, since those are handled by the
TransactionWatcher.Also, external transactions are still fetched for blocks post account addition. This is just a quick win to reduce RPC calls by not adding the block range 0-CurrentBlock when we add the account.
