feat_: accept community join request with mvds #5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (14)
|
kaichaosun
force-pushed
the
comm-join-response
branch
from
5731f15 to
6533e43
Compare
This was referenced Sep 3, 2024
|
@kaichaosun thanks for the PR. Based on mobile testing I have left an issue in mobile PR status-im/status-mobile#21165 (comment) |
kaichaosun
force-pushed
the
comm-join-response
branch
from
6533e43 to
dc0f30b
Compare
kaichaosun
requested review from
qfrank,
osmaczko,
richard-ramos,
plopezlpz and
chaitanyaprem
and removed request for
qfrank
osmaczko
approved these changes
Sep 4, 2024
qfrank
reviewed
Sep 5, 2024
| @@ -2019,6 +2023,12 @@ func (m *Messenger) acceptRequestToJoinCommunity(requestToJoin *communities.Requ | |||
| Priority: &common.HighPriority, | |||
| } | |||
|
|
|||
| if !community.PublicKey().Equal(community.ControlNode()) { | |||
There was a problem hiding this comment.
would be great if you can add a comment on this for future developer 🙂
qfrank
approved these changes
Sep 5, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ApplicationMetadataMessage_COMMUNITY_REQUEST_TO_JOIN_RESPONSE message to use MVDS.
Important changes:
Closes #