chore: bump status-go for community join response use mvds #21165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
53% of end-end tests have passedFailed tests (24)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Passed tests (27)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@kaichaosun thanks for the PR. Please take a look at the issue ISSUE 1 Community request stucks in Pending for more than 1 minute (auto approval community)Steps:
Actual result: sometimes it takes more than a minute. community_request_sender.zip On the video pay attention at request status at the top right corner. It remains Pending for more than a minute. telegram-cloud-document-2-5384059526389452664.mp4 |
1 task
|
@pavloburykh This may relates to the validation logic, https://github.com/status-im/status-go/blob/develop/protocol/communities/manager.go#L3521. MVDS use the sender key (creator key of community) to sign the message. |
kaichaosun
force-pushed
the
comm-join-response-mvds
branch
from
bc0b650 to
b280539
Compare
90% of end-end tests have passedFailed tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Passed tests (46)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
|
@kaichaosun thank you for the fixes. ISSUE 1 seems to be fixed. At the same time, while testing current PR I have faced a critical issue which resulted in braking my account on Android (it crashed couple of times and after that I was not able to login). I do not know if this issue is PR related or not, as there are no steps for reproduction. Would be great if you can check the logs and description below and try to identify what went wrong. ISSUE 2 At some point app has crashed and after that user is unable to loginHere are some steps which I performed by my user before the issue occured:
In the logs there is an error
mobile_user_geth_log.zip telegram-cloud-document-2-5388760552778518755.mp4telegram-cloud-document-2-5388760552778518780.mp4 |
|
@kaichaosun besides ISSUE 2 I do not see any other issues. I faced couple of times community request stucking in Pending on mobile but it can be due to some network issues. In case you do not consider ISSUE 2 PR related you are good to merge. |
|
Thanks @pavloburykh
It seems related to golang-migrate/migrate#79 For ISSUE 2, may caused by #21174, I will bump status go after the fix and let's see if it helps. |
Thank you @kaichaosun. Unfortunately we will not be able to verify if it is fixed or not because there no steps to reproduce, seems it is happening randomly. I was not able to reproduce the issue by another newly created user though I tried to follow the same flow as the user with failed migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
ApplicationMetadataMessage_COMMUNITY_REQUEST_TO_JOIN_RESPONSEmessage to use MVDS.Status-go: status-im/status-go#5787
Review notes
Testing notes
The change should increase the stability of join community process.
Platforms
Areas that maybe impacted
Functional
Non-functional
Steps to test
Before and after screenshots comparison
status: ready
Risk
Described potential risks and worst case scenarios.
Tick one: