Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some exceptions are not very informative for the client code (#221) #222

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: some exceptions are not very informative for the client code (#221) #222

merged 1 commit into from
Jan 18, 2024

Conversation

rkondakov
Copy link
Contributor

Some clarification was added to the non-informative exceptions.

EpsilonPrime
EpsilonPrime approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these improved exceptions should make developers' lives better!

vbarua
vbarua approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clarifications.

@vbarua vbarua merged commit 8c70245 into substrait-io:main Jan 18, 2024
7 checks passed
@davisusanibar davisusanibar mentioned this pull request Feb 4, 2024
Closed
ajegou pushed a commit to ajegou/substrait-java that referenced this pull request Mar 29, 2024
@rkondakov
feat: improved error messages for Substrait conversion failures (subs…
0ae08e4 
…trait-io#221) (substrait-io#222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@vbarua vbarua vbarua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkondakov @EpsilonPrime @vbarua