Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix indexed keyword issue in events #422

Merged
merged 2 commits into from
Jan 15, 2024
Merged

chore: fix indexed keyword issue in events #422

merged 2 commits into from
Jan 15, 2024

Conversation

sujithsomraaj
Copy link
Contributor

No description provided.

Copy link

linear bot commented Jan 8, 2024

@sujithsomraaj sujithsomraaj changed the base branch from main to develop January 8, 2024 07:53
Copy link
Contributor

@vikramarun vikramarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the only remaining places uint256[] indexed is used is in RescueProposed and CrossChainInitiatedWithdrawMulti

@sujithsomraaj
Copy link
Contributor Author

CrossChainInitiatedWithdrawMulti

guess CrossChainInitiatedWithdrawMulti is good, we didn't index any dynamic types

Copy link
Contributor

@vikramarun vikramarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@0xTimepunk 0xTimepunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujithsomraaj sujithsomraaj merged commit 6dd881e into develop Jan 15, 2024
5 checks passed
@sujithsomraaj sujithsomraaj deleted the SUP-5019 branch January 15, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants