Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix indexed keyword issue in events #422

Merged
merged 2 commits into from
Jan 15, 2024
Merged

chore: fix indexed keyword issue in events #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
266d6dc
chore: remove indexed keyword from bytes
sujithsomraaj Jan 8, 2024
f6c0398
fix: indexed in dynamic types
sujithsomraaj Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/crosschain-data/BaseStateRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { PayloadState, AMBMessage, AMBExtraData } from "src/types/DataTypes.sol"
/// mechanisms.
/// @author Zeropoint Labs
abstract contract BaseStateRegistry is IBaseStateRegistry {

using ProofLib for AMBMessage;
using ProofLib for bytes;

Expand Down Expand Up @@ -117,7 +116,7 @@ abstract contract BaseStateRegistry is IBaseStateRegistry {
bytes32 proofHash = abi.decode(data.params, (bytes32));
++messageQuorum[proofHash];

emit ProofReceived(data.params);
emit ProofReceived(proofHash);
} else {
/// @dev if message, store header and body of it
++payloadsCount;
Expand Down
5 changes: 2 additions & 3 deletions src/crosschain-data/adapters/layerzero/LayerzeroImplementation.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { ILayerZeroUserApplicationConfig } from "src/vendor/layerzero/ILayerZero
/// @dev Allows state registries to use Layerzero for crosschain communication
/// @author Zeropoint Labs
contract LayerzeroImplementation is IAmbImplementation, ILayerZeroUserApplicationConfig, ILayerZeroReceiver {

using DataLib for uint256;

//////////////////////////////////////////////////////////////
Expand All @@ -41,8 +40,8 @@ contract LayerzeroImplementation is IAmbImplementation, ILayerZeroUserApplicatio
//////////////////////////////////////////////////////////////

event EndpointUpdated(address indexed oldEndpoint_, address indexed newEndpoint_);
event MessageFailed(uint16 indexed srcChainId_, bytes indexed srcAddress_, uint64 indexed nonce_, bytes payload_);
event SetTrustedRemote(uint16 indexed srcChainId_, bytes indexed srcAddress_);
event MessageFailed(uint16 indexed srcChainId_, bytes srcAddress_, uint64 indexed nonce_, bytes payload_);
event SetTrustedRemote(uint16 indexed srcChainId_, bytes srcAddress_);

//////////////////////////////////////////////////////////////
// MODIFIERS //
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/IBaseStateRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ interface IBaseStateRegistry {

/// @dev is emitted when a cross-chain proof is received in the state registry
/// NOTE: comes handy if quorum required is more than 0
event ProofReceived(bytes indexed proof);
event ProofReceived(bytes32 indexed proof);

/// @dev is emitted when a payload id gets updated
event PayloadUpdated(uint256 indexed payloadId);
Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/ICoreStateRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ interface ICoreStateRegistry {
/// @dev is emitted when a rescue is proposed for failed deposits in a payload
event RescueProposed(
uint256 indexed payloadId,
uint256[] indexed superformIds,
uint256[] indexed proposedAmount,
uint256[] superformIds,
uint256[] proposedAmount,
uint256 proposedTime
);

Expand Down
3 changes: 1 addition & 2 deletions src/interfaces/IPaymentHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
/// @dev Interface for PaymentHelper
/// @author ZeroPoint Labs
interface IPaymentHelper {

//////////////////////////////////////////////////////////////
// STRUCTS //
//////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -50,7 +49,7 @@ interface IPaymentHelper {
// EVENTS //
//////////////////////////////////////////////////////////////

event ChainConfigUpdated(uint64 indexed chainId_, uint256 indexed configType_, bytes indexed config_);
event ChainConfigUpdated(uint64 indexed chainId_, uint256 indexed configType_, bytes config_);
event ChainConfigAdded(uint64 chainId_, PaymentHelperConfig config_);

//////////////////////////////////////////////////////////////
Expand Down