Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve wallet recovery log message #6792

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Feb 6, 2025

Description

Improved the wallet recovery log message:

2025-02-06 09:02:50.398360400 [wallet::utxo_scanning] INFO  Fresh wallet recovery/scanning: Wallet birthday 
'1124' at epoch time '1738108800' with block height '81', scanning from epoch time '1736899200' at block height 
'0' with header hash '68bb2afefbaf579aefcce9a7160c3e503177857df36c7885b1d3af054e253330'

Motivation and Context

When a user sees an info message about recovery, this message will make it clear what the birthday is and what the starting scan height is.

See #6787.

How Has This Been Tested?

System-level testing

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Feb 6, 2025

Test Results (CI)

    3 files    129 suites   38m 34s ⏱️
1 361 tests 1 361 ✅ 0 💤 0 ❌
4 081 runs  4 081 ✅ 0 💤 0 ❌

Results for commit 1b67395.

@SWvheerden SWvheerden changed the title feat: improve wallet recovery log message chore: improve wallet recovery log message Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   50m 6s ⏱️ + 50m 6s
36 tests +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 
38 runs  +38  35 ✅ +35  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 1b67395. ± Comparison against base commit 5a562a5.

@SWvheerden SWvheerden merged commit 9e3ef5b into tari-project:development Feb 6, 2025
18 of 19 checks passed
@hansieodendaal hansieodendaal deleted the ho_improve_wallet_recovery_log branch February 7, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants