Harvesting mask NOC layout #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
force-pushed
the
pjanevski/harvesting_mask_fix
branch
3 times, most recently
from
b8b87af to
7acb0a9
Compare
broskoTT
reviewed
Dec 6, 2024
broskoTT
reviewed
Dec 6, 2024
broskoTT
reviewed
Dec 6, 2024
broskoTT
reviewed
Dec 6, 2024
broskoTT
reviewed
Dec 6, 2024
broskoTT
approved these changes
Dec 6, 2024
pjanevskiTT
force-pushed
the
pjanevski/harvesting_mask_fix
branch
2 times, most recently
from
f4fb469 to
eb5d08b
Compare
pjanevskiTT
force-pushed
the
pjanevski/harvesting_mask_fix
branch
from
eb5d08b to
826717a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
/
Description
Harvesting mask targets tensix rows based on the physical chip layout. So far I have assumed it is NOC layout. This PR is fixing that.
List of the changes
Testing
Unit tests.
API Changes
No API changes