Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Move TTDevice to local chip #396

Merged
merged 6 commits into from
Dec 17, 2024
Merged

[Chip] Move TTDevice to local chip #396

merged 6 commits into from
Dec 17, 2024

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Dec 11, 2024 •
edited
Loading

Issue

Related to #248

Description

Another PR in a push to define Chip class properly.
This PR moves tt_device under Chip, specifically under LocalChips.

List of the changes

  • Add TTDevice to LocalChip
  • Renamed all_chips, target_chips and remote_chips to have more consistent naming.
  • MockChip disabled at the moment, it will start working by itself at some point, when enough stuff is moved to Chip class.

Testing

Existing tests

API Changes

There are no API changes in this PR.

@broskoTT broskoTT force-pushed the brosko/chip_ttdev branch 2 times, most recently from bf3641f to 2ea8197 Compare December 13, 2024 14:00
@broskoTT broskoTT marked this pull request as ready for review December 13, 2024 14:04
@broskoTT broskoTT requested a review from pjanevskiTT December 13, 2024 14:04
pjanevskiTT
pjanevskiTT approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@pjanevskiTT pjanevskiTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few nit comments, mostly naming, otherwise looks good

@broskoTT broskoTT merged commit 4ed53ca into main Dec 17, 2024
21 of 24 checks passed
@broskoTT broskoTT deleted the brosko/chip_ttdev branch December 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanevskiTT pjanevskiTT pjanevskiTT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broskoTT @pjanevskiTT