-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Decompose #108
Merged
thomaskioko
merged 59 commits into
feature/voyager-navigation
from
feature/navigation-rework-decompose
Dec 9, 2023
Merged
Migrate to Decompose #108
thomaskioko
merged 59 commits into
feature/voyager-navigation
from
feature/navigation-rework-decompose
Dec 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[iOS] Migrate to Decompose
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
Android related task/issues
enhancement
New feature or request
shared
Shared module task/issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces a
Voyager
navigation with Decompose. I first tried out Voyager but switched to decompose as it met my needs.At the moment, navigation is only implemented on the Android app. But the "ViewModels" will be shared between Android and iOS. This is handled in the
:navigation
module. With this change, all feature modules are now pure compose modules. No navigation logic. They implement the "ViewModel(Presenter)" all thanks to Decompose magic. 🥳 In short, they have been decomposed.In the future, screens might move to the presentation layer. Still thinking about this. 🤔
Presentation Migration:
Replace the Presentation module with Decompose.
Android Screen Migration and Navigation Setup:
Replace the compose screen setup with the Decompose. This allows us to navigate between different features.
Other Changes
MigrationDemo.mp4
iOS_Demo.mp4
Closes #67 #76 #83
Improvements