Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Decompose #108

Merged

Conversation

thomaskioko
Copy link
Owner

@thomaskioko thomaskioko commented Dec 2, 2023

Description

This PR replaces a Voyager navigation with Decompose. I first tried out Voyager but switched to decompose as it met my needs.

At the moment, navigation is only implemented on the Android app. But the "ViewModels" will be shared between Android and iOS. This is handled in the :navigation module. With this change, all feature modules are now pure compose modules. No navigation logic. They implement the "ViewModel(Presenter)" all thanks to Decompose magic. 🥳 In short, they have been decomposed.

In the future, screens might move to the presentation layer. Still thinking about this. 🤔

Presentation Migration:

Replace the Presentation module with Decompose.

  • Discover.
  • Grid(More)
  • Profile.
  • Season Details.
  • Settings.
  • Show Details
  • Trailers
  • Library

Android Screen Migration and Navigation Setup:

Replace the compose screen setup with the Decompose. This allows us to navigate between different features.

  • Discover.
  • Profile.
  • Season Details.
  • Settings.
  • Show Details
  • Shows Grid
  • Trailers
  • Library

Other Changes

  • Publish new SMP lib.
  • Migrate iOS to use new ScreenModels.
  • Update README.
Android iOS
MigrationDemo.mp4
iOS_Demo.mp4

Closes #67 #76 #83

Improvements

  • Add unit tests.

@thomaskioko thomaskioko mentioned this pull request Dec 9, 2023
5 tasks
@thomaskioko thomaskioko marked this pull request as ready for review December 9, 2023 13:44
@thomaskioko thomaskioko merged commit e8a35d5 into feature/voyager-navigation Dec 9, 2023
5 checks passed
@thomaskioko thomaskioko mentioned this pull request Dec 9, 2023
@thomaskioko thomaskioko deleted the feature/navigation-rework-decompose branch December 9, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android related task/issues enhancement New feature or request shared Shared module task/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant