Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Decompose #108

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
86baa90
Update gradle-wrapper
thomaskioko Nov 29, 2023
e32dd16
Bump up dependency versions.
thomaskioko Nov 29, 2023
9ace80f
Move class to common module.
thomaskioko Nov 29, 2023
161324c
Add packaging options.
thomaskioko Nov 29, 2023
d8a39b0
Cleanup gradle files.
thomaskioko Nov 29, 2023
a891bac
Minor cleanup.
thomaskioko Nov 30, 2023
9b73e3c
Add compose runtime dependencies. Fixes iOS build failure.
thomaskioko Nov 30, 2023
e960cf0
Rename feature directory. Remove android prefix.
thomaskioko Nov 30, 2023
9c57061
Remove voyager add navigation module.
thomaskioko Dec 2, 2023
c5c476d
Migrate trailers presentation module to decompose
thomaskioko Dec 2, 2023
172dfac
Migrate showDetails presentation module to decompose
thomaskioko Dec 2, 2023
6797729
Migrate settings presentation module to decompose
thomaskioko Dec 2, 2023
02a0b0d
Migrate seasonDetails presentation module to decompose
thomaskioko Dec 2, 2023
0675247
Create search presentation module.
thomaskioko Dec 2, 2023
80c6c4e
Migrate profile presentation module to decompose
thomaskioko Dec 2, 2023
4bd826b
Create more-shows presentation module.
thomaskioko Dec 2, 2023
38af3c9
Migrate library presentation module to decompose
thomaskioko Dec 2, 2023
7d57d57
Migrate discover presentation module to decompose
thomaskioko Dec 2, 2023
f584ad6
Use immutable list
thomaskioko Dec 2, 2023
60ad20c
Create root decompose navigation module. 🥳
thomaskioko Dec 2, 2023
48d1dc0
Minor cleanup: Use component activity.
thomaskioko Dec 2, 2023
d376b67
Add logging component
thomaskioko Dec 2, 2023
84aa92f
Decompose feature modules. 🥳 Get rid of FeatureRegistry and cleanup d…
thomaskioko Dec 2, 2023
6d2e6e8
Delete voyager module and remaining classes.
thomaskioko Dec 2, 2023
53f62f6
Cleanup modules and dependencies.
thomaskioko Dec 2, 2023
28758e5
Update import.
thomaskioko Dec 2, 2023
06a0242
Add root navigation component.
thomaskioko Dec 2, 2023
13262f5
Add decompose dependencies and remove unused ones.
thomaskioko Dec 2, 2023
97575a8
Delete feature plugin.
thomaskioko Dec 2, 2023
43f78c3
Update README with decompose dependency.
thomaskioko Dec 2, 2023
ec96967
Remove viewModel and load theme from root presenter.
thomaskioko Dec 2, 2023
fdc1fab
Add Napier for logging. (Trial)
thomaskioko Dec 2, 2023
767906c
Some dependency cleanup: Create SharedComponent
thomaskioko Dec 2, 2023
3dd3a57
Enable ksp companion extension
thomaskioko Dec 2, 2023
df5221d
Borrow some extension goodies from tivi.
thomaskioko Dec 3, 2023
c004429
Make spotless happy
thomaskioko Dec 3, 2023
cd68fdf
Add platform component and fix scoping issue when building iOS framew…
thomaskioko Dec 3, 2023
49b95f9
Add decompose util class from Confetti
thomaskioko Dec 3, 2023
b57c3fb
Add decompose extension dependencies.
thomaskioko Dec 3, 2023
31de0f4
Replace StateFlow with Value and use helper function.
thomaskioko Dec 3, 2023
600d117
Replace collectAsState with decompose subscribeAsState
thomaskioko Dec 3, 2023
f151395
Delete viewModel implementation.
thomaskioko Dec 4, 2023
fd37d06
Minor cleanup: update state and actions.
thomaskioko Dec 5, 2023
75ab4c9
Remove internal keyword. Make it accessible to iOS project.
thomaskioko Dec 5, 2023
51bb9b2
Move framework setup to shared gradle file
thomaskioko Dec 5, 2023
1c5f7c0
Add util dependency
thomaskioko Dec 5, 2023
3cc0bdc
Remove turbine block.
thomaskioko Dec 6, 2023
76299d9
Minor cleanup. Rename theme enum. Fixes conflicts on iOS.
thomaskioko Dec 6, 2023
41fa569
Setup Decompose core navigation on ios 🥳
thomaskioko Dec 6, 2023
8ba30ec
Minor cleanup: Fix wierd naming issue on iOS
thomaskioko Dec 7, 2023
010ad88
Move font our of UI directory
thomaskioko Dec 8, 2023
340a264
Update extensions directory.
thomaskioko Dec 8, 2023
4a6402c
Update ui components directory.
thomaskioko Dec 9, 2023
1af4954
Minor UI improvements and update structure.
thomaskioko Dec 9, 2023
bd928ae
Minor UI tweaks.
thomaskioko Dec 9, 2023
397c82b
Add Library Ui implementation.
thomaskioko Dec 9, 2023
e0bab38
Bump up dependency versions.
thomaskioko Dec 9, 2023
4339f79
Update project configuration.
thomaskioko Dec 9, 2023
965a44f
Merge pull request #109 from thomaskioko/feature/decompose-ios
thomaskioko Dec 9, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ traktRedirectUri: "PUT_CALLBACK_URI_HERE"
* [Kotest Assertions](https://kotest.io/docs/assertions/assertions.html) - Testing
* [SQLDelight](https://github.com/cashapp/sqldelight/) - Local storage
- [Coroutines Extensions](https://cashapp.github.io/sqldelight/js_sqlite/coroutines/) Consume queries as Flow
* [Voyager](https://github.com/adrielcafe/voyager) - A pragmatic navigation library for Jetpack Compose
* [Decompose](https://arkivanov.github.io/Decompose/) - Kotlin Multiplatform library for breaking down your code into lifecycle-aware business logic components (aka BLoC).


### iOS
Expand Down
3 changes: 2 additions & 1 deletion android-core/designsystem/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ dependencies {

implementation(projects.androidCore.resources)

implementation(libs.kenburns)
implementation(libs.androidx.core)
implementation(libs.androidx.compose.foundation)
implementation(libs.androidx.compose.material.icons)
implementation(libs.kenburns)
implementation(libs.kotlinx.collections)
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,23 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import com.thomaskioko.tvmaniac.compose.extensions.copy
import kotlinx.collections.immutable.ImmutableList
import kotlinx.collections.immutable.persistentListOf

@Composable
fun <T> LazyGridItems(
listState: LazyListState,
paddingValues: PaddingValues,
modifier: Modifier = Modifier,
items: List<T> = listOf(),
items: ImmutableList<T> = persistentListOf(),
rows: Int = 3,
hPadding: Int = 8,
hPadding: Int = 0,
itemContent: @Composable (LazyItemScope.(T) -> Unit),
) {
val chunkedList = items.chunked(rows)
LazyColumn(
state = listState,
contentPadding = paddingValues.copy(copyTop = false),
contentPadding = paddingValues,
modifier = modifier
.padding(horizontal = hPadding.dp),
verticalArrangement = Arrangement.spacedBy(4.dp),
Expand Down
22 changes: 0 additions & 22 deletions android-features/discover/build.gradle.kts

This file was deleted.

This file was deleted.

17 changes: 0 additions & 17 deletions android-features/library/build.gradle.kts

This file was deleted.

This file was deleted.

17 changes: 0 additions & 17 deletions android-features/more-shows/build.gradle.kts

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

20 changes: 0 additions & 20 deletions android-features/profile/build.gradle.kts

This file was deleted.

This file was deleted.

11 changes: 0 additions & 11 deletions android-features/search/build.gradle.kts

This file was deleted.

This file was deleted.

This file was deleted.

18 changes: 0 additions & 18 deletions android-features/season-details/build.gradle.kts

This file was deleted.

Loading
Loading