MAIN B-22654 #14906
Draft
MAIN B-22654 #14906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
…es orders to update ppm type of submitted PPMs
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT PR
INT PR 2
Agility ticket
Note
This branch contains the code of B-22653 so please ensure that is merged prior to this one once POA'd
Summary
Here we are setting up the groundwork for a new type of PPM called "Small Package Reimbursement". With the work of B-22653, we now have the database changes and feature flag additions that we need to start work.
This PR specifically focuses on the PPM creation/updating process for the following scenarios:
ppm_typeofINCENTIVE_BASEDif they are NOT civilian employeesppm_typeofACTUAL_EXPENSEif they ARE civilian employeesCIVILIAN_EMPLOYEEor TOCIVILIAN_EMPLOYEE, theppm_typeneeds to be updated if the PPM is still inDRAFTstatusIncentive-basedoption)How to test
FEATURE_FLAG_PPM_SPRflag in yourenvrcclient&serverActual Expense&Small Package)Incentive-basedoption is checked by defaultSmall Package ReimbursementCivilian Employeeand confirm that SCs cannot selectIncentive-basedfor civiliansFEATURE_FLAG_PPM_SPRoff and make sure all is good and no small package things (on the UI side) cannot be seenScreenshots
Non-civilian incentive-based
Non-civilian actual expense
Non-civilian small package
Civilian actual expense
Civilian small package
