Add strong name

[twcclegg]

Changes

[twcclegg]

To be merged before v9.0.0 is released.

[wmundev]

@twcclegg have you tried generating an snk key instead? might help with the build errors - https://learn.microsoft.com/en-us/dotnet/standard/assembly/create-public-private-key-pair#create-a-key-pair

then you can use visual studio to sign it - https://learn.microsoft.com/en-us/dotnet/standard/assembly/sign-strong-name#create-and-sign-an-assembly-with-a-strong-name-by-using-visual-studio

[twcclegg]

Hey Wilson, yeah that’s my general plan. I have to borrow a Windows machine but should be able to do that in the next couple days.

[twcclegg]

@wmundev I have a feeling that this will break PRs from forks (secrets not available), but we can fix that at a later date.
This should be resolved now.

[wmundev]

@twcclegg nice work on the strong naming!

[wmundev]

@twcclegg do you want to consider committing the private key directly to the repo instead of having it in github action secrets?

this is the recommendation by microsoft - https://learn.microsoft.com/en-us/dotnet/standard/assembly/strong-named#what-makes-a-strong-named-assembly

Do not rely on strong names for security. They provide a unique identity only.

If you are an open-source developer and you want the identity benefits of a strong-named assembly for better compatibility with .NET Framework, consider checking in the private key associated with an assembly to your source control system.