-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases + Allow model_configure to provide a path for FV3ATM output #2581 + Update CICD to move label deletion to Jenkinsfile #2568 #2548
Conversation
Confirmed that ufs-community/ccpp-physics@80d5c40 does not impact the results of any tests, so the previous results remain valid. |
Signed-off-by: Bruce Kropp <bruce.kropp@raytheon.com>
@rhaesung can you sync up branches? I may go ahead to do some more pre tests with this pr. |
@jkbk2004 Done! Please let me know if see any issues. |
@rhaesung @FernandoAndrade-NOAA @BrianCurtis-NOAA I confirm this pr runs ok on Derecho: baseline creation and comparison as well. We should let this pr go first. @grantfirl FYI |
Leaving a note that test_changes.list seems incomplete, additional failures during comparison for:
@jkbk2004 FYI |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@BrianCurtis-NOAA we can start merging this pr if we skip acorn. |
@rhaesung new fv3 hash is NOAA-EMC/fv3atm@2c902a6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the wrong logs uploaded for Hera and Gaea C5? Quite a few failure messages in the logs.
I know this is merged and I said Acorn was having issues. Those were resolved and the following Acorn RT Log is proof all is well. |
Well i tried and got permissions denied, but the Acorn logs did pass. |
@BrianCurtis-NOAA I set the next PR (#2587 ) with no baseline change. Good to follow up Acorn test there. |
…temperature and radiative flux biases + Allow model_configure to provide a path for FV3ATM output ufs-community#2581 + Update CICD to move label deletion to Jenkinsfile ufs-community#2568 (ufs-community#2548) * UFSWM - Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases + Allow users to provide custom paths for fv3atm output. Default `./` is retained for the regression testing of the ufs-weather-model + Move CI label deletion to Jenkinsfile * FV3 - Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases * ccpp-physics - Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases
Commit Queue Requirements:
Description:
Changes from @RuiyuSun and @HelinWei-NOAA.
This PR addresses several key issues identified in the HRv4 and UFS/Noah-MP models, focusing on radiative flux biases, soil thermal conductivity, and evapotranspiration improvements. The goal of these updates is to enhance model performance and better align simulations with observed data.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: