Merge pull request #323 from visdesignlab/322-set-naming

Remove `getId` call from set id generation
visdesignlab · Mar 26, 2024 · 40a1573 · 40a1573
2 parents cb64fb6 + 027adf4
commit 40a1573
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/e2e-tests/datatable.spec.ts b/e2e-tests/datatable.spec.ts
@@ -74,7 +74,7 @@ test('Datatable', async ({ page }) => {
   // //////////////////
   const datatable = await page1.getByText('IntersectionSizeSchool & Male3Unincluded3Male3Duff Fan & Male & Power Plant3Evil & Male2Evil & Male & Power Plant2Duff Fan & Male2Blue Hair2School1School & Evil & Male1Rows per page:101–10 of');
   await expect(datatable).toBeVisible();
-  const visibleSets = await page1.getByText('SetSizeSchool6Blue_Hair3Duff_Fan6Evil6Male18Power_Plant5Rows per page:101–6 of');
+  const visibleSets = await page1.getByText('SetSizeSchool6Blue Hair3Duff Fan6Evil6Male18Power Plant5Rows per page:101–6 of');
   await expect(visibleSets).toBeVisible();
   const hiddenSets = await page1.getByText('No rowsSetSizeRows per page:100–0 of');
   await expect(hiddenSets).toBeVisible();

diff --git a/packages/core/src/process.ts b/packages/core/src/process.ts
@@ -216,7 +216,7 @@ function getSets(
   const sets: Sets = {};
   setColumns.forEach((col) => {
     const set: ISet = {
-      id: getId('Set', col),
+      id: `Set_${col}`,
       elementName: col,
       items: setMembership[col],
       type: 'Set',