curl: Add versioned-dep on libcurl-openssl4 #41405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a versioned dependency to make sure curl and libcurl-openssl4 are always the same version. It should technically be more correct for curl to allow for newer libcurl-openssl4 versions, but this likely to avoid more problems. Example use case: 2bda4b8f8b0b:/work/packages# grep curl /etc/apk/world libcurl-openssl4=8.12.0-r0 2bda4b8f8b0b:/work/packages# apk add curl (1/1) Installing curl (8.12.0-r0) Executing glibc-2.40-r8.trigger Executing busybox-1.37.0-r0.trigger OK: 34 MiB in 37 packages 2bda4b8f8b0b:/work/packages# apk add curl=8.12.0-r1 ERROR: unable to select packages: libcurl-openssl4-8.12.0-r0: breaks: curl-8.12.0-r1[libcurl-openssl4=8.12.0-r1] satisfies: world[libcurl-openssl4=8.12.0-r0] curl-8.12.0-r1[so:libcurl.so.4] 2bda4b8f8b0b:/work/packages# apk add curl=8.12.0-r1 libcurl-openssl4=8.12.0-r1 (1/2) Upgrading libcurl-openssl4 (8.12.0-r0 -> 8.12.0-r1) (2/2) Upgrading curl (8.12.0-r0 -> 8.12.0-r1) Executing glibc-2.40-r8.trigger Executing busybox-1.37.0-r0.trigger OK: 34 MiB in 37 packages Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
octo-sts
bot
added
the
bincapz/pass
xnox
requested changes
Feb 5, 2025
|
I don't know how conflicts are processed, and if something like would work. |
Good catch. Could we just build them both from the same YAML? They appear to originate from the same source tree/tag. |
no, as it will cause bootstrap cycle. Also they sometimes are broken with new versions of rust/rustls/rustls-ffi/curl. |
xnox
referenced
this pull request
in jamonation/wolfi-os
Feb 6, 2025
Signed-off-by: Jamon <jamon@chainguard.dev>
|
main...jamonation:wolfi-os:libcurl-depends-provides is my approach adding the virtual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a versioned dependency to make sure curl and
libcurl-openssl4 are always the same version.
It should technically be more correct for curl
to allow for newer libcurl-openssl4 versions,
but this likely to avoid more problems.
Example use case:
2bda4b8f8b0b:/work/packages# grep curl /etc/apk/world libcurl-openssl4=8.12.0-r0
2bda4b8f8b0b:/work/packages# apk add curl
(1/1) Installing curl (8.12.0-r0)
Executing glibc-2.40-r8.trigger
Executing busybox-1.37.0-r0.trigger
OK: 34 MiB in 37 packages
2bda4b8f8b0b:/work/packages# apk add curl=8.12.0-r1 ERROR: unable to select packages:
libcurl-openssl4-8.12.0-r0:
breaks: curl-8.12.0-r1[libcurl-openssl4=8.12.0-r1] satisfies: world[libcurl-openssl4=8.12.0-r0] curl-8.12.0-r1[so:libcurl.so.4] 2bda4b8f8b0b:/work/packages# apk add curl=8.12.0-r1 libcurl-openssl4=8.12.0-r1 (1/2) Upgrading libcurl-openssl4 (8.12.0-r0 -> 8.12.0-r1) (2/2) Upgrading curl (8.12.0-r0 -> 8.12.0-r1)
Executing glibc-2.40-r8.trigger
Executing busybox-1.37.0-r0.trigger
OK: 34 MiB in 37 packages