[Shipping labels] Update local requirements for address fields #14865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #13781
Description
This updates some of the local requirements for address fields in the Woo Shipping label flow. Instead of a fixed set of required fields, this moves the checks for whether a field is required into the view model. This will allow us to update the requirements based on data in the view model.
Changes in this PR:
phoneNumberRequired
property. The phone number is always required for origin addresses but not always required for destination addresses, so this is a step toward making the view and view model useful for both address types.Future PRs will continue to update the local requirements, add validation, and prepare the view model for reuse for destination addresses.
Testing information
*
to indicate the phone number field is required.Note: If both the name and company field are empty, they are both marked as required until one is entered. If both the name and company field are populated, they are both marked as optional until one is cleared.
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: