-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping labels] Make edit address form reusable for both origin and destination addresses #14866
Conversation
Generated by 🚫 Danger |
e8ab012
to
37a3db3
Compare
|
Checking on the build failure with the infra team: p1736878667017449-slack-CC7L49W13 |
@@ -12,19 +23,27 @@ final class WooShippingEditAddressViewModel: ObservableObject, Identifiable { | |||
@Published var postalCode: String | |||
@Published var email: String | |||
@Published var phone: String | |||
@Published var saveAsDefault: Bool | |||
@Published var isDefault: Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, can we make this property more meaningful? What is default here, the address? in that case, can we name it as isDefaultAddress
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good point; updated both the property and the init parameter in babdfa1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 🚢
Part of: #13781
⚠️ Depends on #14865 ⚠️
Description
This makes the address form in the Woo Shipping label flow reusable for editing both origin and destination addresses.
Changes in this PR:
addressType
property to track what type of address is being edited.saveAsDefault
property toisDefault
for clarity.)Testing information
There should be no visible changes to the current behavior:
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: