-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Catch null content errors #21673
Conversation
There are contexts where the JavaScript runtime appears to send null values to the host app. It could be performance related, but we should catch the errors nonetheless.
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:trunk-7a9a66ce400ef1baaa2d098c0f8c95ffe1f42f81
+| \--- org.wordpress.gutenbergkit:android:trunk-7894ff454cf2a889dd4634e031c1a0323d7f3d08
-\--- org.wordpress.gutenbergkit:android:trunk-7a9a66ce400ef1baaa2d098c0f8c95ffe1f42f81 (*)
+\--- org.wordpress.gutenbergkit:android:trunk-7894ff454cf2a889dd4634e031c1a0323d7f3d08 (*) |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21673-3c28b1a | |
Commit | 3c28b1a | |
Direct Download | wordpress-prototype-build-pr21673-3c28b1a.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21673-3c28b1a | |
Commit | 3c28b1a | |
Direct Download | jetpack-prototype-build-pr21673-3c28b1a.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcalhoun This all tested fine, merge when ready
|
There are contexts where the JavaScript runtime appears to send null
values to the host app. It could be performance related, but we should
catch the errors nonetheless.
Related:
To Test:
I was unable to reproduce the crash, so we cannot test the fix. We can test for regressions in the form of saving title and content changes in the editor—save/update button, back button, quit app, etc.
Regression Notes
None likely.
Testing saving title and content changes.
Deemed unnecessary for the experimental feature.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):