Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S390 sec boot2 #704

Merged
merged 3 commits into from
Nov 5, 2024
Merged

S390 sec boot2 #704

merged 3 commits into from
Nov 5, 2024

Conversation

jreidinger
Copy link
Member

Problem

The text in proposal popup regarding s390 is still not precise. On running system it is correct.

Solution

Keep the text in sync and also note it in code to avoid such issue next time.

Testing

  • no testing as it is just text change and text is identical and both parts use dialog, so it should also fit.

@coveralls
Copy link

coveralls commented Nov 5, 2024

Coverage Status

coverage: 87.915% (-0.2%) from 88.092%
when pulling ab3504c on s390_sec_boot2
into 53d796c on SLE-15-SP6.

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit 6628f68 into SLE-15-SP6 Nov 5, 2024
12 checks passed
@jreidinger jreidinger deleted the s390_sec_boot2 branch November 5, 2024 10:06
@yast-bot
Copy link
Contributor

yast-bot commented Nov 5, 2024

✔️ Internal Jenkins job #6 successfully finished
✔️ Created IBS submit request #351162

This was referenced Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants