Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S390 sec boot2 #704

Merged
merged 3 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Metrics/BlockLength:

# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 30 # TODO this should be lower for new code
Max: 31 # TODO this should be lower for new code
Include:
- 'src/lib/**/*.rb' # be more strict for new code in lib

Expand Down
7 changes: 7 additions & 0 deletions package/yast2-bootloader.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
-------------------------------------------------------------------
Tue Nov 5 09:57:58 UTC 2024 - Josef Reidinger <jreidinger@suse.com>

- Sync warning text from s390 secure boot to be identical in
installation proposal and on running system (bsc#1219989)
- 4.6.8

-------------------------------------------------------------------
Fri Apr 5 08:08:09 UTC 2024 - Josef Reidinger <jreidinger@suse.com>

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-bootloader.spec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


Name: yast2-bootloader
Version: 4.6.7
Version: 4.6.8
Release: 0
Summary: YaST2 - Bootloader Configuration
License: GPL-2.0-or-later
Expand Down
1 change: 1 addition & 0 deletions src/lib/bootloader/grub2_widgets.rb
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ def validate
value == Systeminfo.secure_boot_active?

Yast::Popup.ContinueCancel(
# text is identical like one in proposal client. Keep in sync!
# TRANSLATORS: IPL stands for Initial Program Load, IBM speak for system boot
_(
"Secure boot IPL has the following minimum system requirements,\n" \
Expand Down
11 changes: 8 additions & 3 deletions src/lib/bootloader/proposal_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,15 @@ def single_click_action(option, value)
bootloader.secure_boot = value
if value && Yast::Arch.s390
Yast2::Popup.show(
# text is identical like one in grub2_widgets. Keep in sync!
# TRANSLATORS: IPL stands for Initial Program Load, IBM speak for system boot
_(
"The new secure-boot enabled boot data format works only on z15 " \
"and later and only for zFCP disks.\n\n" \
"The system does not boot if these requirements are not met."
"Secure boot IPL has the following minimum system requirements,\n" \
"depending on the boot device to be IPLed:\n" \
"NVMe disk: IBM LinuxONE III or newer.\n" \
"FC-attached SCSI disk: IBM LinuxONE III, IBM z15 or newer.\n" \
"ECKD DASD with CDL layout: IBM z16, LinuxONE 4 or newer.\n" \
"If these requirements are not met, the system can be IPLed in non-secure mode only."
),
headline: :warning, buttons: :ok
)
Expand Down
Loading