-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial demo setup for HPP pick and place plan #43
Merged
MaximilienNaveau
merged 69 commits into
agimus-project:humble-devel
from
kzorina:hpp_test_code
Mar 6, 2025
Merged
Initial demo setup for HPP pick and place plan #43
MaximilienNaveau
merged 69 commits into
agimus-project:humble-devel
from
kzorina:hpp_test_code
Mar 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…e' into hpp_test_code
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
MaximilienNaveau
previously approved these changes
Mar 3, 2025
I'll let @kzorina integrate the changes related to the xacro files and test on her side. The remaining comments are all either no work or a very small work. I'm fine merging quickly after that. It shouldn't take very long. |
I am fine keeping it as a PR to solve these small issues for now as long as it doesn't impair your abilities to collaborate. |
This was referenced Mar 5, 2025
for more information, see https://pre-commit.ci
MaximilienNaveau
approved these changes
Mar 5, 2025
jmirabel
approved these changes
Mar 5, 2025
MaximilienNaveau
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is adapted and simplifeid a bit from
https://github.com/TheoMF/agimus-demos-franka-manipulation/blob/working/script_hpp.py
For now only works in pick and place scenario with hardcoded start and goal object poses.
There is also an obstacle, but so far I moved it far away
This PR is also based on PR that Max was doing for orchestrator