Add support for store schemas in ROS 2 msg format [19866] #89

irenebm · 2023-10-27T09:38:42Z

Merge after:

codecov-commenter · 2023-11-08T09:06:08Z

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f9ecc14) 20.03% compared to head (4a11ff5) 19.80%.

Files	Patch %	Lines
...participants/src/cpp/recorder/mcap/McapHandler.cpp	10.00%	2 Missing and 7 partials ⚠️
...cipants/src/cpp/replayer/McapReaderParticipant.cpp	0.00%	0 Missing and 4 partials ⚠️
ddsreplayer/src/cpp/tool/DdsReplayer.cpp	0.00%	0 Missing and 4 partials ⚠️
..._yaml/src/cpp/recorder/YamlReaderConfiguration.cpp	0.00%	2 Missing ⚠️
ddsrecorder/src/cpp/tool/DdsRecorder.cpp	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   20.03%   19.80%   -0.24%     
==========================================
  Files          29       29              
  Lines        2700     2712      +12     
  Branches     1412     1423      +11     
==========================================
- Hits          541      537       -4     
- Misses       1704     1721      +17     
+ Partials      455      454       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jepemi

LGTM with green CI.

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

jepemi

LGTM

ddsrecorder/src/cpp/tool/DdsRecorder.cpp

ddsrecorder_participants/CMakeLists.txt

ddsrecorder_participants/src/cpp/recorder/mcap/McapHandler.cpp

ddsrecorder_participants/src/cpp/replayer/McapReaderParticipant.cpp

ddsreplayer/src/cpp/tool/DdsReplayer.cpp

docs/rst/notes/forthcoming_version.rst

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

juanlofer-eprosima

LGTM

irenebm had a problem deploying to codecov October 27, 2023 09:38 — with GitHub Actions Failure

irenebm changed the title ~~Add support for store schemas in ROS 2 msg format~~ Add support for store schemas in ROS 2 msg format [19693] Oct 30, 2023

irenebm changed the title ~~Add support for store schemas in ROS 2 msg format [19693]~~ Add support for store schemas in ROS 2 msg format [19866] Nov 6, 2023

irenebm force-pushed the feature/ros2_mangling branch from 8c0e11b to 685efb1 Compare November 7, 2023 15:55

irenebm had a problem deploying to codecov November 7, 2023 15:55 — with GitHub Actions Failure

irenebm force-pushed the feature/ros2_mangling branch from 685efb1 to d107960 Compare November 8, 2023 07:30

irenebm temporarily deployed to codecov November 8, 2023 07:31 — with GitHub Actions Inactive

irenebm marked this pull request as ready for review November 8, 2023 17:52

irenebm had a problem deploying to codecov November 8, 2023 17:53 — with GitHub Actions Failure

This comment was marked as resolved.

Sign in to view

irenebm had a problem deploying to codecov November 14, 2023 08:06 — with GitHub Actions Failure

irenebm temporarily deployed to codecov November 14, 2023 14:19 — with GitHub Actions Inactive

irenebm had a problem deploying to codecov November 14, 2023 15:50 — with GitHub Actions Error

irenebm temporarily deployed to codecov November 15, 2023 07:02 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov November 15, 2023 08:24 — with GitHub Actions Inactive

irenebm force-pushed the feature/ros2_mangling branch from 51aa4b5 to e0b6794 Compare November 15, 2023 08:37

irenebm temporarily deployed to codecov November 15, 2023 08:37 — with GitHub Actions Inactive

irenebm force-pushed the feature/ros2_mangling branch from e0b6794 to c67fa05 Compare November 15, 2023 08:57

irenebm temporarily deployed to codecov November 15, 2023 08:57 — with GitHub Actions Inactive

irenebm force-pushed the feature/ros2_mangling branch from c67fa05 to f0f8cbc Compare November 15, 2023 10:32

irenebm had a problem deploying to codecov November 15, 2023 10:32 — with GitHub Actions Failure

irenebm force-pushed the feature/ros2_mangling branch from f0f8cbc to 612b04c Compare November 15, 2023 10:40

irenebm temporarily deployed to codecov November 15, 2023 10:40 — with GitHub Actions Inactive

irenebm force-pushed the feature/ros2_mangling branch from 612b04c to 32f835b Compare November 15, 2023 11:02

irenebm temporarily deployed to codecov November 15, 2023 11:02 — with GitHub Actions Inactive

irenebm force-pushed the feature/ros2_mangling branch from 32f835b to ced2811 Compare November 15, 2023 11:33

irenebm had a problem deploying to codecov November 15, 2023 11:33 — with GitHub Actions Error

irenebm force-pushed the feature/ros2_mangling branch from ced2811 to 5be51ff Compare November 15, 2023 11:57

irenebm force-pushed the feature/ros2_mangling branch from 258d7f0 to f983436 Compare November 20, 2023 08:54

irenebm temporarily deployed to codecov November 20, 2023 08:54 — with GitHub Actions Inactive

jepemi previously approved these changes Nov 20, 2023

View reviewed changes

irenebm force-pushed the feature/ros2_mangling branch from f983436 to fcae8b0 Compare November 21, 2023 16:05

irenebm temporarily deployed to codecov November 21, 2023 16:05 — with GitHub Actions Inactive

irenebm added 10 commits November 23, 2023 17:02

Add support for store schemas in OMG IDL and ROS 2 msg format

2faf236

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Add documentation

a925ffb

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Add tests recorder

e1e526e

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Fix tests

2bc024f

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Replayer implementation

c51f00f

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Apply changes

f3eb93c

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Add ros2_types to metadata

f629a38

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Fix test CI

071f6d1

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Apply changes

17b7e47

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Add replayer test

4ccad5f

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm dismissed jepemi’s stale review via 4ccad5f November 23, 2023 16:03

irenebm force-pushed the feature/ros2_mangling branch from fcae8b0 to 4ccad5f Compare November 23, 2023 16:03

irenebm temporarily deployed to codecov November 23, 2023 16:03 — with GitHub Actions Inactive

jepemi previously approved these changes Nov 24, 2023

View reviewed changes

juanlofer-eprosima requested changes Nov 24, 2023

View reviewed changes

irenebm dismissed jepemi’s stale review via 0e9e661 November 24, 2023 10:09

irenebm temporarily deployed to codecov November 24, 2023 10:09 — with GitHub Actions Inactive

Apply changes

a776e89

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm force-pushed the feature/ros2_mangling branch from 0e9e661 to a776e89 Compare November 24, 2023 11:25

irenebm temporarily deployed to codecov November 24, 2023 11:25 — with GitHub Actions Inactive

Apply changes

4a11ff5

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm temporarily deployed to codecov November 24, 2023 12:39 — with GitHub Actions Inactive

juanlofer-eprosima approved these changes Nov 24, 2023

View reviewed changes

irenebm merged commit b008805 into main Nov 24, 2023
17 checks passed

irenebm deleted the feature/ros2_mangling branch November 24, 2023 13:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for store schemas in ROS 2 msg format [19866] #89

Add support for store schemas in ROS 2 msg format [19866] #89

irenebm commented Oct 27, 2023 •

edited

Loading

codecov-commenter commented Nov 8, 2023 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

jepemi left a comment

jepemi left a comment

juanlofer-eprosima left a comment

Add support for store schemas in ROS 2 msg format [19866] #89

Add support for store schemas in ROS 2 msg format [19866] #89

Conversation

irenebm commented Oct 27, 2023 • edited Loading

codecov-commenter commented Nov 8, 2023 • edited Loading

Codecov Report

This comment was marked as resolved.

This comment was marked as resolved.

jepemi left a comment

Choose a reason for hiding this comment

jepemi left a comment

Choose a reason for hiding this comment

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

irenebm commented Oct 27, 2023 •

edited

Loading

codecov-commenter commented Nov 8, 2023 •

edited

Loading