Fix checkpoint flag assignment error (#42) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinzakka
approved these changes
Feb 24, 2025
|
Thanks @vincentzhang, I'm working on a big refactor of these scripts that will make things better, would be great to get your input when I make the PR. Note I used notebooks during this project so never encountered any of these script edge cases. |
|
Good to know. Thanks. |
copybara-service
bot
merged commit 609168a
into
google-deepmind:main
3 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #42 by avoiding assignment to the read-only flag property .value.
Use a local variable to store the resolved checkpoint path.