Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Automating release creation #734

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
This PR is

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2024
@adilGhaffarDev
Copy link
Member Author

documentation needs to be updated I am working on it.

@adilGhaffarDev adilGhaffarDev force-pushed the automate-release/adil branch 2 times, most recently from 8e2c21e to 2b00e1e Compare November 7, 2024 13:15
Makefile Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@adilGhaffarDev adilGhaffarDev force-pushed the automate-release/adil branch 2 times, most recently from 310c4af to ca754b1 Compare November 8, 2024 13:17
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
@adilGhaffarDev adilGhaffarDev changed the title [wip]🌱 Automating release creation 🌱 Automating release creation Nov 8, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
.github/workflows/release.yaml Outdated Show resolved Hide resolved
hack/tools/go.mod Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Nov 8, 2024

Also, let's design this so that we can replicate it to all releasable repos here. For other workflows, we have moved the boilerplate code to project-infra and then simply call it from repo being released with correct params. Makes much less maintenance in the long run, when updates need to go in one repo only.

Here we of course have the release note code in the repo, which might make it difficult, but at least check if above is possible?

@adilGhaffarDev
Copy link
Member Author

Also, let's design this so that we can replicate it to all releasable repos here. For other workflows, we have moved the boilerplate code to project-infra and then simply call it from repo being released with correct params. Makes much less maintenance in the long run, when updates need to go in one repo only.

Yes, @mquhuy was also suggesting that. I will check.

@adilGhaffarDev
Copy link
Member Author

As discussed, let's proceed with merging this change and test it in the upcoming patch releases. Once verified, I'll open a pull request in project-infra to add a common workflow script for IPAM, CAPM3, and BMO.
cc @tuminoid @Rozzii

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

@peppi-lotta @smoshiur1237 @Sunnatillo please review

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@adilGhaffarDev
Copy link
Member Author

/retest

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice improvement

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@Sunnatillo
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@mquhuy mquhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adilGhaffarDev , this looks like a very good change!

I had some nits from initial reviews, may come back with more later if I have time.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
@kashifest
Copy link
Member

/hold cancel
ready for review

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

We need to have documents in more finished state. I realize we need further tuning after we've done a release, but at least the steps should be corrected. Now there is too much old stuff that should not be done by release team at all.

docs/releasing.md Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@adilGhaffarDev
Copy link
Member Author

/test markdownlint

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test markdownlint

docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Lets take this baby for a test ride!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@tuminoid
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
@metal3-io-bot metal3-io-bot merged commit 77f0793 into metal3-io:main Nov 28, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the automate-release/adil branch November 28, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants