-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Automating release creation #734
Conversation
documentation needs to be updated I am working on it. |
8e2c21e
to
2b00e1e
Compare
2b00e1e
to
ab5071a
Compare
310c4af
to
ca754b1
Compare
ca754b1
to
a4d3a78
Compare
a4d3a78
to
5b6dc2f
Compare
5b6dc2f
to
9eb35b5
Compare
Also, let's design this so that we can replicate it to all releasable repos here. For other workflows, we have moved the boilerplate code to project-infra and then simply call it from repo being released with correct params. Makes much less maintenance in the long run, when updates need to go in one repo only. Here we of course have the release note code in the repo, which might make it difficult, but at least check if above is possible? |
Yes, @mquhuy was also suggesting that. I will check. |
/test metal3-centos-e2e-integration-test-main |
@peppi-lotta @smoshiur1237 @Sunnatillo please review |
9eb35b5
to
cbfd432
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Nice improvement
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adilGhaffarDev , this looks like a very good change!
I had some nits from initial reviews, may come back with more later if I have time.
cbfd432
to
a3677ea
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
We need to have documents in more finished state. I realize we need further tuning after we've done a release, but at least the steps should be corrected. Now there is too much old stuff that should not be done by release team at all.
a3677ea
to
2ab3f2f
Compare
/test markdownlint |
1 similar comment
/test markdownlint |
2ab3f2f
to
c622a2f
Compare
c622a2f
to
9afaf11
Compare
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
9afaf11
to
dc95bbb
Compare
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Lets take this baby for a test ride!
/unhold |
What this PR does / why we need it:
This PR is
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #