Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update includes for generate_parameter_library 0.4.0 #3255

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

sea-bass
Copy link
Contributor

Description

Now that generate_parameter_library changed the default install location of headers, this PR gets rid of deprecation warnings.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass added the backport-jazzy Mergify label that triggers a PR backport to Jazzy label Jan 20, 2025
@sea-bass sea-bass force-pushed the update-generated-params-includes branch from 86b90f4 to f85c5a8 Compare January 20, 2025 18:07
@sea-bass sea-bass force-pushed the update-generated-params-includes branch from f85c5a8 to c37dc3c Compare January 20, 2025 18:10
@sea-bass
Copy link
Contributor Author

FYI: Humble sync is tomorrow (2025-01-21), so I'll rerun this again then.

@mikeferguson
Copy link
Contributor

Which version of generate_parameter_library made this change? And is it released in humble, jazzy and rolling?

@sea-bass
Copy link
Contributor Author

sea-bass commented Jan 20, 2025

Which version of generate_parameter_library made this change? And is it released in humble, jazzy and rolling?

0.4.0 -- released in Jazzy and Rolling, and will be out on Humble tomorrow (2025-01-21).

Copy link
Contributor

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes

@sea-bass sea-bass force-pushed the update-generated-params-includes branch from 89d6917 to c37dc3c Compare January 20, 2025 19:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (2b9173b) to head (7a6beda).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
- Coverage   46.06%   45.63%   -0.43%     
==========================================
  Files         714      714              
  Lines       62319    62298      -21     
  Branches     7534     7530       -4     
==========================================
- Hits        28700    28421     -279     
- Misses      33452    33710     +258     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass force-pushed the update-generated-params-includes branch 3 times, most recently from f393a52 to 86d28c7 Compare January 20, 2025 20:54
@sea-bass sea-bass force-pushed the update-generated-params-includes branch from 86d28c7 to 7a6beda Compare January 20, 2025 21:13
@sea-bass sea-bass requested a review from mikeferguson January 22, 2025 01:11
@sea-bass
Copy link
Contributor Author

OK, this branch is now good to go!

@sea-bass sea-bass added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit e11cabb Jan 22, 2025
12 checks passed
@sea-bass sea-bass deleted the update-generated-params-includes branch January 22, 2025 02:17
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
* Update includes for generate_parameter_library 0.4.0

* Fix header prefix in IKFast template

(cherry picked from commit e11cabb)
sea-bass added a commit that referenced this pull request Jan 22, 2025
(cherry picked from commit e11cabb)

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants