-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta-qc utils per # 87 #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - one minor suggested change but not a blocker for merging.
Couple of thoughts:
-- Consistently get 500 error for syn30058753 - not sure if this is a problem with the API or the dataset?
-- For syn50698189, one of the validation failures is '' is too short
which I don't really know what it is referring to. Is this as-is from the API?
|
Close issue #87 (basic pass/fail grading, does not cover letter-grading, which has moved to #122).
This is somewhat inefficient and we could still benefit from a specialized validation service, but it's nevertheless an improvement over the status quo regarding re-validation needs as discussed in Slack.
Test
meta_qc_dataset
andmeta_qc_project
to see how well they work so far; I know there will be cases where these could still be better.Also, you might prefer to use
manifest_generate
now that the API is stable -- should be much more ergonomic to use than the DCA UI, schematic command line, or the Swagger UI.Some examples: